Commit 0355911a authored by Emil Tsalapatis's avatar Emil Tsalapatis Committed by Andrii Nakryiko
Browse files

selftests/bpf: Explicitly account for globals in verifier_arena_large 



The big_alloc1 test in verifier_arena_large assumes that the arena base
and the first page allocated by bpf_arena_alloc_pages are identical.
This is not the case, because the first page in the arena is populated
by global arena data. The test still passes because the code makes the
tacit assumption that the first page is on offset PAGE_SIZE instead of
0.

Make this distinction explicit in the code, and adjust the page offsets
requested during the test to count from the beginning of the arena
instead of using the address of the first allocated page.

Signed-off-by: default avatarEmil Tsalapatis <emil@etsalapatis.com>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Reviewed-by: default avatarEduard Zingerman <eddyz87@gmail.com>
Link: https://lore.kernel.org/bpf/20251216173325.98465-2-emil@etsalapatis.com
parent 6f0b824a

tools/testing/selftests/bpf/progs/verifier_arena_large.c

+11 −4
Original line number Diff line number Diff line
@@ -23,18 +23,25 @@ int big_alloc1(void *ctx) 
{

#if defined(__BPF_FEATURE_ADDR_SPACE_CAST)

	volatile char __arena *page1, *page2, *no_page, *page3;

	void __arena *base;

	u64 base;



	page1 = base = bpf_arena_alloc_pages(&arena, NULL, 1, NUMA_NO_NODE, 0);

	base = (u64)arena_base(&arena);



	page1 = bpf_arena_alloc_pages(&arena, NULL, 1, NUMA_NO_NODE, 0);

	if (!page1)

		return 1;



	/* Account for global arena data. */

	if ((u64)page1 != base + PAGE_SIZE)

		return 15;



	*page1 = 1;

	page2 = bpf_arena_alloc_pages(&arena, base + ARENA_SIZE - PAGE_SIZE * 2,

	page2 = bpf_arena_alloc_pages(&arena, (void __arena *)(ARENA_SIZE - PAGE_SIZE),

				      1, NUMA_NO_NODE, 0);

	if (!page2)

		return 2;

	*page2 = 2;

	no_page = bpf_arena_alloc_pages(&arena, base + ARENA_SIZE - PAGE_SIZE,

	no_page = bpf_arena_alloc_pages(&arena, (void __arena *)ARENA_SIZE,

					1, NUMA_NO_NODE, 0);

	if (no_page)

		return 3;