Commit 0364ca33 authored by Alok Tiwari's avatar Alok Tiwari Committed by Jakub Kicinski
Browse files

devlink: region: correct port region lookup to use port_ops 



The function devlink_port_region_get_by_name() incorrectly uses
region->ops->name to compare the region name. as it is not any critical
impact as ops and port_ops define as union for devlink_region but as per
code logic it should refer port_ops here.

No functional impact as ops and port_ops are part of same union,
and name is the first member of both.

Update it to use region->port_ops->name to properly reference
the name of the devlink port region.

Signed-off-by: default avatarAlok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Link: https://patch.msgid.link/20251020170916.1741808-1-alok.a.tiwari@oracle.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3ff9bcec

net/devlink/region.c

+1 −1
Original line number Diff line number Diff line
@@ -50,7 +50,7 @@ devlink_port_region_get_by_name(struct devlink_port *port, 
	struct devlink_region *region;



	list_for_each_entry(region, &port->region_list, list)

		if (!strcmp(region->ops->name, region_name))

		if (!strcmp(region->port_ops->name, region_name))

			return region;



	return NULL;