Commit 0381e588 authored Feb 28, 2024 by Geert Uytterhoeven Committed by Petr Mladek Mar 19, 2024

dyndbg: Use *no_printk() helpers



When printk-indexing is enabled, each printk() or dev_printk()
invocation emits a pi_entry structure.  This is even true when the call
is protected by an always-false check: while the actual code to print
the message is optimized out by the compiler, the pi_entry structure is
still emitted.

Fix this by replacing "if (0) *printk(...)" constructs by calls to the
corresponding *no_printk() helpers.

Note that this has minimal impact, as most (all?) callers of
dynamic_{pr,dev}_debug() are protected by checks for DYNAMIC_DEBUG
anyway.  Still, using the helpers serves as a good example to follow.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Chris Down <chris@chrisdown.name>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/32e18ceb528b99d9147be9c1af578a1965e2bad9.1709127473.git.geert+renesas@glider.be


Signed-off-by: Petr Mladek <pmladek@suse.com>

parent c26ec799

include/linux/dynamic_debug.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -305,9 +305,9 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
		#define DYNAMIC_DEBUG_BRANCH(descriptor) false

		#define dynamic_pr_debug(fmt, ...) \
		do { if (0) printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__); } while (0)
		no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
		#define dynamic_dev_dbg(dev, fmt, ...) \
		do { if (0) dev_printk(KERN_DEBUG, dev, fmt, ##__VA_ARGS__); } while (0)
		dev_no_printk(KERN_DEBUG, dev, fmt, ##__VA_ARGS__)
		#define dynamic_hex_dump(prefix_str, prefix_type, rowsize, \
		groupsize, buf, len, ascii) \
		do { if (0) \