Commit 038aa1f0 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Linus Walleij
Browse files

gpio: dwapb: Refactor IRQ handler to use bit operations 



Refactor IRQ handler in order to use for_each_set_bit() helper.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: default avatarSerge Semin <fancer.lancer@gmail.com>
Reviewed-by: default avatarSerge Semin <fancer.lancer@gmail.com>
Link: https://lore.kernel.org/r/20200415141534.31240-3-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent c58220cb

drivers/gpio/gpio-dwapb.c

+7 −8
Original line number Diff line number Diff line
@@ -193,22 +193,21 @@ static void dwapb_toggle_trigger(struct dwapb_gpio *gpio, unsigned int offs) 


static u32 dwapb_do_irq(struct dwapb_gpio *gpio)

{

	u32 irq_status = dwapb_read(gpio, GPIO_INTSTATUS);

	u32 ret = irq_status;

	unsigned long irq_status;

	int hwirq;



	while (irq_status) {

		int hwirq = fls(irq_status) - 1;

	irq_status = dwapb_read(gpio, GPIO_INTSTATUS);

	for_each_set_bit(hwirq, &irq_status, 32) {

		int gpio_irq = irq_find_mapping(gpio->domain, hwirq);

		u32 irq_type = irq_get_trigger_type(gpio_irq);



		generic_handle_irq(gpio_irq);

		irq_status &= ~BIT(hwirq);



		if ((irq_get_trigger_type(gpio_irq) & IRQ_TYPE_SENSE_MASK)

			== IRQ_TYPE_EDGE_BOTH)

		if ((irq_type & IRQ_TYPE_SENSE_MASK) == IRQ_TYPE_EDGE_BOTH)

			dwapb_toggle_trigger(gpio, hwirq);

	}



	return ret;

	return irq_status;

}



static void dwapb_irq_handler(struct irq_desc *desc)