Unverified Commit 038ac18a authored by Samuel Holland's avatar Samuel Holland Committed by Palmer Dabbelt
Browse files

riscv: mm: Broadcast kernel TLB flushes only when needed 



__flush_tlb_range() avoids broadcasting TLB flushes when an mm context
is only active on the local CPU. Apply this same optimization to TLB
flushes of kernel memory when only one CPU is online. This check can be
constant-folded when SMP is disabled.

Reviewed-by: default avatarAlexandre Ghiti <alexghiti@rivosinc.com>
Signed-off-by: default avatarSamuel Holland <samuel.holland@sifive.com>
Link: https://lore.kernel.org/r/20240327045035.368512-5-samuel.holland@sifive.com


Signed-off-by: default avatarPalmer Dabbelt <palmer@rivosinc.com>
parent dc892fb4

arch/riscv/mm/tlbflush.c

+5 −13
Original line number Diff line number Diff line
@@ -103,22 +103,15 @@ static void __flush_tlb_range(struct cpumask *cmask, unsigned long asid, 
			      unsigned long start, unsigned long size,

			      unsigned long stride)

{

	bool broadcast;

	unsigned int cpu;



	if (cpumask_empty(cmask))

		return;



	if (cmask != cpu_online_mask) {

		unsigned int cpuid;

	cpu = get_cpu();



		cpuid = get_cpu();

		/* check if the tlbflush needs to be sent to other CPUs */

		broadcast = cpumask_any_but(cmask, cpuid) < nr_cpu_ids;

	} else {

		broadcast = true;

	}



	if (!broadcast) {

	/* Check if the TLB flush needs to be sent to other CPUs. */

	if (cpumask_any_but(cmask, cpu) >= nr_cpu_ids) {

		local_flush_tlb_range_asid(start, size, stride, asid);

	} else if (riscv_use_sbi_for_rfence()) {

		sbi_remote_sfence_vma_asid(cmask, start, size, asid);
@@ -132,7 +125,6 @@ static void __flush_tlb_range(struct cpumask *cmask, unsigned long asid, 
		on_each_cpu_mask(cmask, __ipi_flush_tlb_range_asid, &ftd, 1);

	}



	if (cmask != cpu_online_mask)

	put_cpu();

}