Commit 03b54bad authored by Joshua Washington's avatar Joshua Washington Committed by Jakub Kicinski
Browse files

gve: Fix XDP TX completion handling when counters overflow 



In gve_clean_xdp_done, the driver processes the TX completions based on
a 32-bit NIC counter and a 32-bit completion counter stored in the tx
queue.

Fix the for loop so that the counter wraparound is handled correctly.

Fixes: 75eaae15 ("gve: Add XDP DROP and TX support for GQI-QPL format")
Signed-off-by: default avatarJoshua Washington <joshwash@google.com>
Signed-off-by: default avatarPraveen Kaligineedi <pkaligineedi@google.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240716171041.1561142-1-pkaligineedi@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 0e03c643

drivers/net/ethernet/google/gve/gve_tx.c

+3 −2
Original line number Diff line number Diff line
@@ -158,15 +158,16 @@ static int gve_clean_xdp_done(struct gve_priv *priv, struct gve_tx_ring *tx, 
			      u32 to_do)

{

	struct gve_tx_buffer_state *info;

	u32 clean_end = tx->done + to_do;

	u64 pkts = 0, bytes = 0;

	size_t space_freed = 0;

	u32 xsk_complete = 0;

	u32 idx;

	int i;



	for (; tx->done < clean_end; tx->done++) {

	for (i = 0; i < to_do; i++) {

		idx = tx->done & tx->mask;

		info = &tx->info[idx];

		tx->done++;



		if (unlikely(!info->xdp.size))

			continue;