Commit 03cc77b1 authored by Puranjay Mohan's avatar Puranjay Mohan Committed by Alexei Starovoitov
Browse files

selftests: bpf: Update failure message for rbtree_fail 



The rbtree_api_use_unchecked_remove_retval() selftest passes a pointer
received from bpf_rbtree_remove() to bpf_rbtree_add() without checking
for NULL, this was earlier caught by __check_ptr_off_reg() in the
verifier. Now the verifier assumes every kfunc only takes trusted pointer
arguments, so it catches this NULL pointer earlier in the path and
provides a more accurate failure message.

Acked-by: default avatarEduard Zingerman <eddyz87@gmail.com>
Reviewed-by: default avatarEmil Tsalapatis <emil@etsalapatis.com>
Signed-off-by: default avatarPuranjay Mohan <puranjay@kernel.org>
Link: https://lore.kernel.org/r/20260102180038.2708325-8-puranjay@kernel.org


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent df500457

tools/testing/selftests/bpf/progs/rbtree_fail.c

+1 −1
Original line number Diff line number Diff line
@@ -153,7 +153,7 @@ long rbtree_api_add_to_multiple_trees(void *ctx) 
}



SEC("?tc")

__failure __msg("dereference of modified ptr_or_null_ ptr R2 off=16 disallowed")

__failure __msg("Possibly NULL pointer passed to trusted arg1")

long rbtree_api_use_unchecked_remove_retval(void *ctx)

{

	struct bpf_rb_node *res;