Commit 03e79de4 authored by Stefan Wahren's avatar Stefan Wahren Committed by Jakub Kicinski
Browse files

net: fec: Fix possible NPD in fec_enet_phy_reset_after_clk_enable() 



The function of_phy_find_device may return NULL, so we need to take
care before dereferencing phy_dev.

Fixes: 64a632da ("net: fec: Fix phy_device lookup for phy_reset_after_clk_enable()")
Signed-off-by: default avatarStefan Wahren <wahrenst@gmx.net>
Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc: Richard Leitner <richard.leitner@skidata.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Reviewed-by: default avatarWei Fang <wei.fang@nxp.com>
Link: https://patch.msgid.link/20250904091334.53965-1-wahrenst@gmx.net


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 157cf360

drivers/net/ethernet/freescale/fec_main.c

+2 −1
Original line number Diff line number Diff line
@@ -2363,6 +2363,7 @@ static void fec_enet_phy_reset_after_clk_enable(struct net_device *ndev) 
		 */

		phy_dev = of_phy_find_device(fep->phy_node);

		phy_reset_after_clk_enable(phy_dev);

		if (phy_dev)

			put_device(&phy_dev->mdio.dev);

	}

}