Commit 03ec41c1 authored by Hans de Goede's avatar Hans de Goede Committed by Sebastian Reichel
Browse files

power: supply: rt9467-charger: Remove "usb_type" property write support 



The "usb_type" property must be read-only for charger power-supply devices,
see: Documentation/ABI/testing/sysfs-class-power.

But the rt9467 driver allows writing 0/1 to it to disable/enable charging.
Other charger drivers use the "status" property for this and the rt9467
code also allows writing 0/1 to its "status" property and this does
the exact same thing as writing 0/1 to its "usb_type" property.

Drop write support for the "usb_type" property making it readonly to match
the ABI documentation. If userspace wants to disable/enable charging it
can use the "status" property for this.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20240831142039.28830-4-hdegoede@redhat.com


Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent 83a4c42d

drivers/power/supply/rt9467-charger.c

+0 −3
Original line number Diff line number Diff line
@@ -745,8 +745,6 @@ static int rt9467_psy_set_property(struct power_supply *psy, 
						    RT9467_RANGE_IPREC, val->intval);

	case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT:

		return rt9467_psy_set_ieoc(data, val->intval);

	case POWER_SUPPLY_PROP_USB_TYPE:

		return regmap_field_write(data->rm_field[F_USBCHGEN], val->intval);

	default:

		return -EINVAL;

	}
@@ -764,7 +762,6 @@ static int rt9467_chg_prop_is_writeable(struct power_supply *psy, 
	case POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT:

	case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT:

	case POWER_SUPPLY_PROP_PRECHARGE_CURRENT:

	case POWER_SUPPLY_PROP_USB_TYPE:

		return 1;

	default:

		return 0;