Commit 03f83209 authored by SeongJae Park's avatar SeongJae Park Committed by Andrew Morton
Browse files

selftests/damon/_damon_sysfs: read tried regions directories in order 

Kdamond.update_schemes_tried_regions() reads and stores tried regions
information out of address order.  It makes debugging a test failure
difficult.  Change the behavior to do the reading and writing in the
address order.

Link: https://lkml.kernel.org/r/20250513002715.40126-6-sj@kernel.org


Signed-off-by: default avatarSeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 094fb149

tools/testing/selftests/damon/_damon_sysfs.py

+5 −0
Original line number Diff line number Diff line
@@ -420,11 +420,16 @@ class Kdamond: 
                tried_regions = []

                tried_regions_dir = os.path.join(

                        scheme.sysfs_dir(), 'tried_regions')

                region_indices = []

                for filename in os.listdir(

                        os.path.join(scheme.sysfs_dir(), 'tried_regions')):

                    tried_region_dir = os.path.join(tried_regions_dir, filename)

                    if not os.path.isdir(tried_region_dir):

                        continue

                    region_indices.append(int(filename))

                for region_idx in sorted(region_indices):

                    tried_region_dir = os.path.join(tried_regions_dir,

                                                    '%d' % region_idx)

                    region_values = []

                    for f in ['start', 'end', 'nr_accesses', 'age']:

                        content, err = read_file(