Commit 0403e10b authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (nct6775-core) Fix underflows seen when writing limit attributes 



DIV_ROUND_CLOSEST() after kstrtol() results in an underflow if a large
negative number such as -9223372036854775808 is provided by the user.
Fix it by reordering clamp_val() and DIV_ROUND_CLOSEST() operations.

Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent af64e3e1

drivers/hwmon/nct6775-core.c

+1 −1
Original line number Diff line number Diff line
@@ -2262,7 +2262,7 @@ store_temp_offset(struct device *dev, struct device_attribute *attr, 
	if (err < 0)

		return err;



	val = clamp_val(DIV_ROUND_CLOSEST(val, 1000), -128, 127);

	val = DIV_ROUND_CLOSEST(clamp_val(val, -128000, 127000), 1000);



	mutex_lock(&data->update_lock);

	data->temp_offset[nr] = val;