Commit 0435bcc4 authored by Johan Hovold's avatar Johan Hovold Committed by Thomas Gleixner
Browse files

irqchip/bcm2712-mip: Fix OF node reference imbalance 



The init callback must not decrement the reference count of the provided
irqchip OF node.

This should not cause any trouble currently, but if the driver ever
starts probe deferring it could lead to warnings about reference
underflow and saturation.

Fixes: 32c6c054 ("irqchip: Add Broadcom BCM2712 MSI-X interrupt controller")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
parent 3a866087

drivers/irqchip/irq-bcm2712-mip.c

+0 −1
Original line number Diff line number Diff line
@@ -239,7 +239,6 @@ static int __init mip_of_msi_init(struct device_node *node, struct device_node * 
	int ret;



	pdev = of_find_device_by_node(node);

	of_node_put(node);

	if (!pdev)

		return -EPROBE_DEFER;