Commit 046eda65 authored by Shuicheng Lin's avatar Shuicheng Lin Committed by Lucas De Marchi
Browse files

drm/xe/devcoredump: Remove IS_ERR_OR_NULL check for kzalloc 



kzalloc returns a valid pointer or NULL if the allocation fails.
It never returns an error pointer. It is better to check for NULL directly.

Signed-off-by: default avatarShuicheng Lin <shuicheng.lin@intel.com>
Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: default avatarTejas Upadhyay <tejas.upadhyay@intel.com>
Reviewed-by: default avatarJonathan Cavitt <jonathan.cavitt@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250220001710.1803749-3-shuicheng.lin@intel.com


Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
parent c504ad91

drivers/gpu/drm/xe/xe_devcoredump.c

+2 −2
Original line number Diff line number Diff line
@@ -426,8 +426,8 @@ void xe_print_blob_ascii85(struct drm_printer *p, const char *prefix, char suffi 
		drm_printf(p, "Offset not word aligned: %zu", offset);



	line_buff = kzalloc(DMESG_MAX_LINE_LEN, GFP_KERNEL);

	if (IS_ERR_OR_NULL(line_buff)) {

		drm_printf(p, "Failed to allocate line buffer: %pe", line_buff);

	if (!line_buff) {

		drm_printf(p, "Failed to allocate line buffer\n");

		return;

	}