Commit 0471921e authored by Jacqueline Wong's avatar Jacqueline Wong Committed by Jarkko Sakkinen
Browse files

tpm: tpm_tis: add error logging for data transfer 



Add logging to more easily determine reason for transmit failure

Cc: stable@vger.kernel.org # v6.6+
Fixes: 280db21e ("tpm_tis: Resend command to recover from data transfer errors")
Signed-off-by: default avatarJacqueline Wong <jacqwong@google.com>
Signed-off-by: default avatarJordan Hand <jhand@google.com>
Link: https://lore.kernel.org/r/20260415160006.2275325-2-jacqwong@google.com


Signed-off-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
parent 6f1d4d2e

drivers/char/tpm/tpm_tis_core.c

+4 −0
Original line number Diff line number Diff line
@@ -471,6 +471,8 @@ static int tpm_tis_send_data(struct tpm_chip *chip, const u8 *buf, size_t len) 
		status = tpm_tis_status(chip);

		if (!itpm && (status & TPM_STS_DATA_EXPECT) == 0) {

			rc = -EIO;

			dev_err(&chip->dev, "TPM_STS_DATA_EXPECT should be set. sts = 0x%08x\n",

				status);

			goto out_err;

		}

	}
@@ -491,6 +493,8 @@ static int tpm_tis_send_data(struct tpm_chip *chip, const u8 *buf, size_t len) 
	status = tpm_tis_status(chip);

	if (!itpm && (status & TPM_STS_DATA_EXPECT) != 0) {

		rc = -EIO;

		dev_err(&chip->dev, "TPM_STS_DATA_EXPECT should be unset. sts = 0x%08x\n",

			status);

		goto out_err;

	}