Commit 0491f3f9 authored by Xuewen Yan's avatar Xuewen Yan Committed by Rafael J. Wysocki
Browse files

PM: sleep: core: Avoid bit field races related to work_in_progress 



In all of the system suspend transition phases, the async processing of
a device may be carried out in parallel with power.work_in_progress
updates for the device's parent or suppliers and if it touches bit
fields from the same group (for example, power.must_resume or
power.wakeup_path), bit field corruption is possible.

To avoid that, turn work_in_progress in struct dev_pm_info into a proper
bool field and relocate it to save space.

Fixes: aa7a9275 ("PM: sleep: Suspend async parents after suspending children")
Fixes: 443046d1 ("PM: sleep: Make suspend of devices more asynchronous")
Signed-off-by: default avatarXuewen Yan <xuewen.yan@unisoc.com>
Closes: https://lore.kernel.org/linux-pm/20260203063459.12808-1-xuewen.yan@unisoc.com/
Cc: All applicable <stable@vger.kernel.org>
[ rjw: Added subject and changelog ]
Link: https://patch.msgid.link/CAB8ipk_VX2VPm706Jwa1=8NSA7_btWL2ieXmBgHr2JcULEP76g@mail.gmail.com


Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 5c9ecd8e

include/linux/pm.h

+1 −1
Original line number Diff line number Diff line
@@ -681,10 +681,10 @@ struct dev_pm_info { 
	struct list_head	entry;

	struct completion	completion;

	struct wakeup_source	*wakeup;

	bool			work_in_progress;	/* Owned by the PM core */

	bool			wakeup_path:1;

	bool			syscore:1;

	bool			no_pm_callbacks:1;	/* Owned by the PM core */

	bool			work_in_progress:1;	/* Owned by the PM core */

	bool			smart_suspend:1;	/* Owned by the PM core */

	bool			must_resume:1;		/* Owned by the PM core */

	bool			may_skip_resume:1;	/* Set by subsystems */