Commit 049f7113 authored by Tzung-Bi Shih's avatar Tzung-Bi Shih Committed by Bartosz Golaszewski
Browse files

gpio: Remove redundant check for struct gpio_chip 



gpiolib_dbg_show() is only called by gpiolib_seq_show() which has
ensured the struct gpio_chip.  Remove the redundant check in
gpiolib_dbg_show().

Reviewed-by: default avatarLinus Walleij <linusw@kernel.org>
Signed-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
Link: https://patch.msgid.link/20260223061726.82161-3-tzungbi@kernel.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
parent cc11f4ef

drivers/gpio/gpiolib.c

+2 −11
Original line number Diff line number Diff line
@@ -5322,23 +5322,14 @@ core_initcall(gpiolib_dev_init); 


#ifdef CONFIG_DEBUG_FS



static void gpiolib_dbg_show(struct seq_file *s, struct gpio_device *gdev)

static void gpiolib_dbg_show(struct seq_file *s, struct gpio_chip *gc)

{

	bool active_low, is_irq, is_out;

	struct gpio_desc *desc;

	unsigned int gpio = 0;

	struct gpio_chip *gc;

	unsigned long flags;

	int value;



	guard(srcu)(&gdev->srcu);



	gc = srcu_dereference(gdev->chip, &gdev->srcu);

	if (!gc) {

		seq_puts(s, "Underlying GPIO chip is gone\n");

		return;

	}



	for_each_gpio_desc(gc, desc) {

		guard(srcu)(&desc->gdev->desc_srcu);

		flags = READ_ONCE(desc->flags);
@@ -5451,7 +5442,7 @@ static int gpiolib_seq_show(struct seq_file *s, void *v) 
	if (gc->dbg_show)

		gc->dbg_show(s, gc);

	else

		gpiolib_dbg_show(s, gdev);

		gpiolib_dbg_show(s, gc);



	return 0;

}