Commit 04f4f33c authored Jul 31, 2024 by Rob Herring (Arm) Committed by Joerg Roedel Sep 04, 2024

iommu: Use of_property_present()



Use of_property_present() to test for property presence rather than
of_(find|get)_property(). This is part of a larger effort to remove
callers of of_find_property() and similar functions. of_find_property()
leaks the DT struct property and data pointers which is a problem for
dynamically allocated nodes which may be freed.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/20240731191312.1710417-6-robh@kernel.org


Signed-off-by: Joerg Roedel <jroedel@suse.de>

parent 84b2baf4

drivers/iommu/fsl_pamu_domain.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -416,14 +416,12 @@ static struct iommu_group fsl_pamu_device_group(struct device dev)

		static struct iommu_device fsl_pamu_probe_device(struct device dev)
		{
		int len;

		/*
		* uboot must fill the fsl,liodn for platform devices to be supported by
		* the iommu.
		*/
		if (!dev_is_pci(dev) &&
		!of_get_property(dev->of_node, "fsl,liodn", &len))
		!of_property_present(dev->of_node, "fsl,liodn"))
		return ERR_PTR(-ENODEV);

		return &pamu_iommu;

drivers/iommu/of_iommu.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -214,7 +214,7 @@ void of_iommu_get_resv_regions(struct device dev, struct list_head list)
		* that represent reservations in the IOVA space, which are regions that should
		* not be mapped.
		*/
		if (of_find_property(it.node, "reg", NULL)) {
		if (of_property_present(it.node, "reg")) {
		err = of_address_to_resource(it.node, 0, &phys);
		if (err < 0) {
		dev_err(dev, "failed to parse memory region %pOF: %d\n",