Commit 051fff35 authored by Jani Nikula's avatar Jani Nikula
Browse files

drm/i915/gt: prefer _PICK_EVEN() over _PICK() 



There's no need to use _PICK() here. Use the simpler one instead.

Reviewed-by: default avatarMichał Grzelak <michal.grzelak@intel.com>
Acked-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patch.msgid.link/f94272fb9e93afa51d9fdb006888b8ebe38580df.1772042022.git.jani.nikula@intel.com


Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
parent 3c35731b

drivers/gpu/drm/i915/gt/intel_gt_regs.h

+3 −5
Original line number Diff line number Diff line
@@ -321,11 +321,9 @@ 
#define _RING_FAULT_REG_VCS			0x4194

#define _RING_FAULT_REG_BCS			0x4294

#define _RING_FAULT_REG_VECS			0x4394

#define RING_FAULT_REG(engine)			_MMIO(_PICK((engine)->class, \

#define RING_FAULT_REG(engine)			_MMIO(_PICK_EVEN((engine)->class, \

								 _RING_FAULT_REG_RCS, \

							    _RING_FAULT_REG_VCS, \

							    _RING_FAULT_REG_VECS, \

							    _RING_FAULT_REG_BCS))

								 _RING_FAULT_REG_VCS))

#define   RING_FAULT_VADDR_MASK			REG_GENMASK(31, 12) /* pre-bdw */

#define   RING_FAULT_ENGINE_ID_MASK		REG_GENMASK(16, 12) /* bdw+ */

#define   RING_FAULT_GTTSEL_MASK		REG_BIT(11) /* pre-bdw */