Unverified Commit 053c4099 authored by Nitin Joshi's avatar Nitin Joshi Committed by Ilpo Järvinen
Browse files

platform/x86: thinkpad-acpi: replace strcpy with strscpy 

strcpy() performs no bounds checking on the destination buffer. This
could result in linear overflows beyond the end of the buffer, leading
to all kinds of misbehaviors.[1]

[1]: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy



Signed-off-by: default avatarNitin Joshi <nitjoshi@gmail.com>
Reviewed-by: default avatarMark Pearson <mpearson-lenovo@squebb.ca>
Link: https://lore.kernel.org/r/20250107021507.4786-1-nitjoshi@gmail.com


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 595c4b67

drivers/platform/x86/thinkpad_acpi.c

+1 −1
Original line number Diff line number Diff line
@@ -11681,7 +11681,7 @@ static int __init set_ibm_param(const char *val, const struct kernel_param *kp) 
		if (strcmp(ibm->name, kp->name) == 0 && ibm->write) {

			if (strlen(val) > sizeof(ibms_init[i].param) - 1)

				return -ENOSPC;

			strcpy(ibms_init[i].param, val);

			strscpy(ibms_init[i].param, val);

			return 0;

		}

	}