Commit 0550069c authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Steven Rostedt (Google)
Browse files

tracing: Properly process error handling in event_hist_trigger_parse() 

Memory allocated with trigger_data_alloc() requires trigger_data_free()
for proper cleanup.

Replace kfree() with trigger_data_free() to fix this.

Found via static analysis and code review.

This isn't a real bug due to the current code basically being an open
coded version of trigger_data_free() without the synchronization. The
synchronization isn't needed as this is the error path of creation and
there's nothing to synchronize against yet. Replace the kfree() to be
consistent with the allocation.

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Tom Zanussi <zanussi@kernel.org>
Link: https://patch.msgid.link/20251211100058.2381268-1-linmq006@gmail.com


Fixes: e1f187d0 ("tracing: Have existing event_command.parse() implementations use helpers")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent 63804fed

kernel/trace/trace_events_hist.c

+1 −1
Original line number Diff line number Diff line
@@ -6911,7 +6911,7 @@ static int event_hist_trigger_parse(struct event_command *cmd_ops, 


	remove_hist_vars(hist_data);



	kfree(trigger_data);

	trigger_data_free(trigger_data);



	destroy_hist_data(hist_data);

	goto out;