Commit 056bce63 authored by Pavan Chebbi's avatar Pavan Chebbi Committed by Jakub Kicinski
Browse files

bnxt_en: Make PTP TX timestamp HWRM query silent 



In a busy network, especially with flow control enabled, we may
experience timestamp query failures fairly regularly. After a while,
dmesg may be flooded with timestamp query failure error messages.

Silence the error message from the low level hwrm function that
sends the firmware message.  Change netdev_err() to netdev_WARN_ONCE()
if this FW call ever fails.

Signed-off-by: default avatarPavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Link: https://lore.kernel.org/r/20231212005122.2401-14-michael.chan@broadcom.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 84793a49

drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c

+3 −3
Original line number Diff line number Diff line
@@ -129,7 +129,7 @@ static int bnxt_hwrm_port_ts_query(struct bnxt *bp, u32 flags, u64 *ts) 
	}

	resp = hwrm_req_hold(bp, req);



	rc = hwrm_req_send(bp, req);

	rc = hwrm_req_send_silent(bp, req);

	if (!rc)

		*ts = le64_to_cpu(resp->ptp_msg_ts);

	hwrm_req_drop(bp, req);
@@ -684,8 +684,8 @@ static void bnxt_stamp_tx_skb(struct bnxt *bp, struct sk_buff *skb) 
		timestamp.hwtstamp = ns_to_ktime(ns);

		skb_tstamp_tx(ptp->tx_skb, &timestamp);

	} else {

		netdev_err(bp->dev, "TS query for TX timer failed rc = %x\n",

			   rc);

		netdev_WARN_ONCE(bp->dev,

				 "TS query for TX timer failed rc = %x\n", rc);

	}



	dev_kfree_skb_any(ptp->tx_skb);