Commit 05763885 authored by Li Huafei's avatar Li Huafei Committed by Ingo Molnar
Browse files

watchdog/hardlockup/perf: Warn if watchdog_ev is leaked 



When creating a new perf_event for the hardlockup watchdog, it should not
happen that the old perf_event is not released.

Introduce a WARN_ONCE() that should never trigger.

[ mingo: Changed the type of the warning to WARN_ONCE(). ]

Signed-off-by: default avatarLi Huafei <lihuafei1@huawei.com>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20241021193004.308303-2-lihuafei1@huawei.com
parent d6834d9c

kernel/watchdog_perf.c

+1 −0
Original line number Diff line number Diff line
@@ -144,6 +144,7 @@ static int hardlockup_detector_event_create(void) 
			 PTR_ERR(evt));

		return PTR_ERR(evt);

	}

	WARN_ONCE(this_cpu_read(watchdog_ev), "unexpected watchdog_ev leak");

	this_cpu_write(watchdog_ev, evt);

	return 0;

}