Unverified Commit 0587e83c authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: samsung: s3c24xx_simtec: add missing error check 



cppcheck warning:

sound/soc/samsung/s3c24xx_simtec.c:191:7: style: Variable 'ret' is
assigned a value that is never used. [unreadVariable]
  ret = snd_soc_dai_set_clkdiv(cpu_dai, S3C24XX_DIV_PRESCALER,
      ^

Looking at the code, it's not clear why the return value is checked in
the two other cases but not here, so mirror the behavior and add a
check.

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20210219230918.5058-3-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 5a81abc2

sound/soc/samsung/s3c24xx_simtec.c

+5 −0
Original line number Diff line number Diff line
@@ -190,6 +190,11 @@ static int simtec_hw_params(struct snd_pcm_substream *substream, 


		ret = snd_soc_dai_set_clkdiv(cpu_dai, S3C24XX_DIV_PRESCALER,

					     cdclk_scale);

		if (ret) {

			pr_err("%s: failed to set clock div\n",

			       __func__);

			return ret;

		}

	}



	return 0;