Commit 059ca8fd authored by Zhongqiu Han's avatar Zhongqiu Han Committed by Jeff Johnson
Browse files

wifi: ath10k: use = {} to initialize bmi_target_info instead of memset 



Initialize the bmi_target_info structure using = {} at declaration time
instead of calling memset() in each bus-specific code path. This
simplifies the code and avoids an explicit memset.

Signed-off-by: default avatarZhongqiu Han <zhongqiu.han@oss.qualcomm.com>
Reviewed-by: default avatarVasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
Link: https://patch.msgid.link/20251030130023.1836808-3-zhongqiu.han@oss.qualcomm.com


Signed-off-by: default avatarJeff Johnson <jeff.johnson@oss.qualcomm.com>
parent 877f9c22

drivers/net/wireless/ath/ath10k/core.c

+1 −4
Original line number Diff line number Diff line
@@ -3352,7 +3352,7 @@ EXPORT_SYMBOL(ath10k_core_stop); 
 */

static int ath10k_core_probe_fw(struct ath10k *ar)

{

	struct bmi_target_info target_info;

	struct bmi_target_info target_info = {};

	int ret = 0;



	ret = ath10k_hif_power_up(ar, ATH10K_FIRMWARE_MODE_NORMAL);
@@ -3363,7 +3363,6 @@ static int ath10k_core_probe_fw(struct ath10k *ar) 


	switch (ar->hif.bus) {

	case ATH10K_BUS_SDIO:

		memset(&target_info, 0, sizeof(target_info));

		ret = ath10k_bmi_get_target_info_sdio(ar, &target_info);

		if (ret) {

			ath10k_err(ar, "could not get target info (%d)\n", ret);
@@ -3375,7 +3374,6 @@ static int ath10k_core_probe_fw(struct ath10k *ar) 
	case ATH10K_BUS_PCI:

	case ATH10K_BUS_AHB:

	case ATH10K_BUS_USB:

		memset(&target_info, 0, sizeof(target_info));

		ret = ath10k_bmi_get_target_info(ar, &target_info);

		if (ret) {

			ath10k_err(ar, "could not get target info (%d)\n", ret);
@@ -3385,7 +3383,6 @@ static int ath10k_core_probe_fw(struct ath10k *ar) 
		ar->hw->wiphy->hw_version = target_info.version;

		break;

	case ATH10K_BUS_SNOC:

		memset(&target_info, 0, sizeof(target_info));

		ret = ath10k_hif_get_target_info(ar, &target_info);

		if (ret) {

			ath10k_err(ar, "could not get target info (%d)\n", ret);