Commit 05be0287 authored by Huacai Chen's avatar Huacai Chen Committed by Andrew Morton
Browse files

mm: remove unnecessary __GFP_HIGHMEM in __p*d_alloc_one_*() 

__{pgd,p4d,pud,pmd,pte}_alloc_one_*() always allocate pages with GFP flag
GFP_PGTABLE_KERNEL/GFP_PGTABLE_USER.  These two macros are defined as
follows:

 #define GFP_PGTABLE_KERNEL	(GFP_KERNEL | __GFP_ZERO)
 #define GFP_PGTABLE_USER	(GFP_PGTABLE_KERNEL | __GFP_ACCOUNT)

There is no __GFP_HIGHMEM in them, so we needn't to clear __GFP_HIGHMEM
explicitly.

Link: https://lkml.kernel.org/r/20251109021817.346181-1-chenhuacai@loongson.cn
Link: https://lkml.kernel.org/r/20251107095536.3101371-1-chenhuacai@loongson.cn


Signed-off-by: default avatarHuacai Chen <chenhuacai@loongson.cn>
Acked-by: default avatarMike Rapoport (Microsoft) <rppt@kernel.org>
Reviewed-by: default avatarVishal Moola (Oracle) <vishal.moola@gmail.com>
Reviewed-by: default avatarAnshuman Khandual <anshuman.khandual@arm.com>
Reviewed-by: default avatarKevin Brodsky <kevin.brodsky@arm.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Jan Kara <jack@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent c0ae966f

include/asm-generic/pgalloc.h

+1 −5
Original line number Diff line number Diff line
@@ -18,8 +18,7 @@ 
 */

static inline pte_t *__pte_alloc_one_kernel_noprof(struct mm_struct *mm)

{

	struct ptdesc *ptdesc = pagetable_alloc_noprof(GFP_PGTABLE_KERNEL &

			~__GFP_HIGHMEM, 0);

	struct ptdesc *ptdesc = pagetable_alloc_noprof(GFP_PGTABLE_KERNEL, 0);



	if (!ptdesc)

		return NULL;
@@ -178,7 +177,6 @@ static inline pud_t *__pud_alloc_one_noprof(struct mm_struct *mm, unsigned long 


	if (mm == &init_mm)

		gfp = GFP_PGTABLE_KERNEL;

	gfp &= ~__GFP_HIGHMEM;



	ptdesc = pagetable_alloc_noprof(gfp, 0);

	if (!ptdesc)
@@ -236,7 +234,6 @@ static inline p4d_t *__p4d_alloc_one_noprof(struct mm_struct *mm, unsigned long 


	if (mm == &init_mm)

		gfp = GFP_PGTABLE_KERNEL;

	gfp &= ~__GFP_HIGHMEM;



	ptdesc = pagetable_alloc_noprof(gfp, 0);

	if (!ptdesc)
@@ -284,7 +281,6 @@ static inline pgd_t *__pgd_alloc_noprof(struct mm_struct *mm, unsigned int order 


	if (mm == &init_mm)

		gfp = GFP_PGTABLE_KERNEL;

	gfp &= ~__GFP_HIGHMEM;



	ptdesc = pagetable_alloc_noprof(gfp, order);

	if (!ptdesc)