Commit 05d98004 authored by Shyam Sundar S K's avatar Shyam Sundar S K Committed by Andi Shyti
Browse files

i2c: piix4: Export i2c_piix4 driver functions as library 



Export the following i2c_piix4 driver functions as a library so that the
AMD ASF driver can utilize these core functionalities from the i2c_piix4
driver:

- piix4_sb800_region_request(): Request access to a specific SMBus region
on the SB800 chipset.

- piix4_sb800_region_release(): Release the previously requested SMBus
region on the SB800 chipset.

- piix4_transaction(): Handle SMBus transactions between the SMBus
controller and connected devices.

- piix4_sb800_port_sel(): Select the appropriate SMBus port on the SB800
chipset.

By making these functions available as a library, enable the AMD ASF
driver to leverage the established mechanisms in the i2c_piix4 driver,
promoting code reuse and consistency across different drivers.

Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Co-developed-by: default avatarSanket Goswami <Sanket.Goswami@amd.com>
Signed-off-by: default avatarSanket Goswami <Sanket.Goswami@amd.com>
Signed-off-by: default avatarShyam Sundar S K <Shyam-sundar.S-k@amd.com>
Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
parent 650e2c39

drivers/i2c/busses/i2c-piix4.c

+8 −6
Original line number Diff line number Diff line
@@ -156,8 +156,7 @@ struct i2c_piix4_adapdata { 
	struct sb800_mmio_cfg mmio_cfg;

};



static int piix4_sb800_region_request(struct device *dev,

				      struct sb800_mmio_cfg *mmio_cfg)

int piix4_sb800_region_request(struct device *dev, struct sb800_mmio_cfg *mmio_cfg)

{

	if (mmio_cfg->use_mmio) {

		void __iomem *addr;
@@ -195,9 +194,9 @@ static int piix4_sb800_region_request(struct device *dev, 


	return 0;

}

EXPORT_SYMBOL_NS_GPL(piix4_sb800_region_request, PIIX4_SMBUS);



static void piix4_sb800_region_release(struct device *dev,

				       struct sb800_mmio_cfg *mmio_cfg)

void piix4_sb800_region_release(struct device *dev, struct sb800_mmio_cfg *mmio_cfg)

{

	if (mmio_cfg->use_mmio) {

		iounmap(mmio_cfg->addr);
@@ -208,6 +207,7 @@ static void piix4_sb800_region_release(struct device *dev, 


	release_region(SB800_PIIX4_SMB_IDX, SB800_PIIX4_SMB_MAP_SIZE);

}

EXPORT_SYMBOL_NS_GPL(piix4_sb800_region_release, PIIX4_SMBUS);



static bool piix4_sb800_use_mmio(struct pci_dev *PIIX4_dev)

{
@@ -517,7 +517,7 @@ static int piix4_setup_aux(struct pci_dev *PIIX4_dev, 
	return piix4_smba;

}



static int piix4_transaction(struct i2c_adapter *piix4_adapter, unsigned short piix4_smba)

int piix4_transaction(struct i2c_adapter *piix4_adapter, unsigned short piix4_smba)

{

	int temp;

	int result = 0;
@@ -590,6 +590,7 @@ static int piix4_transaction(struct i2c_adapter *piix4_adapter, unsigned short p 
		inb_p(SMBHSTDAT1));

	return result;

}

EXPORT_SYMBOL_NS_GPL(piix4_transaction, PIIX4_SMBUS);



/* Return negative errno on error. */

static s32 piix4_access(struct i2c_adapter * adap, u16 addr,
@@ -743,7 +744,7 @@ static void piix4_imc_wakeup(void) 
	release_region(KERNCZ_IMC_IDX, 2);

}



static int piix4_sb800_port_sel(u8 port, struct sb800_mmio_cfg *mmio_cfg)

int piix4_sb800_port_sel(u8 port, struct sb800_mmio_cfg *mmio_cfg)

{

	u8 smba_en_lo, val;
@@ -765,6 +766,7 @@ static int piix4_sb800_port_sel(u8 port, struct sb800_mmio_cfg *mmio_cfg) 


	return (smba_en_lo & piix4_port_mask_sb800);

}

EXPORT_SYMBOL_NS_GPL(piix4_sb800_port_sel, PIIX4_SMBUS);



/*

 * Handles access to multiple SMBus ports on the SB800.

drivers/i2c/busses/i2c-piix4.h

+5 −0
Original line number Diff line number Diff line
@@ -36,4 +36,9 @@ struct sb800_mmio_cfg { 
	bool use_mmio;

};



int piix4_sb800_port_sel(u8 port, struct sb800_mmio_cfg *mmio_cfg);

int piix4_transaction(struct i2c_adapter *piix4_adapter, unsigned short piix4_smba);

int piix4_sb800_region_request(struct device *dev, struct sb800_mmio_cfg *mmio_cfg);

void piix4_sb800_region_release(struct device *dev, struct sb800_mmio_cfg *mmio_cfg);



#endif /* I2C_PIIX4_H */