Commit 06133ddc authored by Philipp Stanner's avatar Philipp Stanner Committed by Jakub Kicinski
Browse files

net: thunder_bgx: Use pure PCI devres API 



The currently used function pci_request_regions() is one of the
problematic "hybrid devres" PCI functions, which are sometimes managed
through devres, and sometimes not (depending on whether
pci_enable_device() or pcim_enable_device() has been called before).

The PCI subsystem wants to remove this behavior and, therefore, needs to
port all users to functions that don't have this problem.

Furthermore, the PCI function being managed implies that it's not
necessary to call pci_release_regions() manually.

Remove the calls to pci_release_regions().

Replace pci_request_regions() with pcim_request_all_regions().

Signed-off-by: default avatarPhilipp Stanner <phasta@kernel.org>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250425085740.65304-9-phasta@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent fad4d94d

drivers/net/ethernet/cavium/thunder/thunder_bgx.c

+2 −5
Original line number Diff line number Diff line
@@ -1605,7 +1605,7 @@ static int bgx_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
		return dev_err_probe(dev, err, "Failed to enable PCI device\n");

	}



	err = pci_request_regions(pdev, DRV_NAME);

	err = pcim_request_all_regions(pdev, DRV_NAME);

	if (err) {

		dev_err(dev, "PCI request regions failed 0x%x\n", err);

		goto err_disable_device;
@@ -1616,7 +1616,7 @@ static int bgx_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
	if (!bgx->reg_base) {

		dev_err(dev, "BGX: Cannot map CSR memory space, aborting\n");

		err = -ENOMEM;

		goto err_release_regions;

		goto err_disable_device;

	}



	set_max_bgx_per_node(pdev);
@@ -1688,8 +1688,6 @@ static int bgx_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
err_enable:

	bgx_vnic[bgx->bgx_id] = NULL;

	pci_free_irq(pdev, GMPX_GMI_TX_INT, bgx);

err_release_regions:

	pci_release_regions(pdev);

err_disable_device:

	pci_disable_device(pdev);

	pci_set_drvdata(pdev, NULL);
@@ -1710,7 +1708,6 @@ static void bgx_remove(struct pci_dev *pdev) 
	pci_free_irq(pdev, GMPX_GMI_TX_INT, bgx);



	bgx_vnic[bgx->bgx_id] = NULL;

	pci_release_regions(pdev);

	pci_disable_device(pdev);

	pci_set_drvdata(pdev, NULL);

}