Commit 066b8f3f authored Sep 05, 2025 by Qianfeng Rong Committed by Martin K. Petersen Sep 16, 2025

scsi: qla2xxx: edif: Fix incorrect sign of error code

Change the error code EAGAIN to -EAGAIN in qla24xx_sadb_update() and
qla_edif_process_els() to align with qla2x00_start_sp() returning
negative error codes or QLA_SUCCESS, preventing logical errors.

Fixes: 0b3f3143 ("scsi: qla2xxx: edif: Add retry for ELS passthrough")
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Message-ID: <20250905075446.381139-2-rongqianfeng@vivo.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 8f5ae30d

drivers/scsi/qla2xxx/qla_edif.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1798,7 +1798,7 @@ qla24xx_sadb_update(struct bsg_job *bsg_job)
		switch (rval) {
		case QLA_SUCCESS:
		break;
		case EAGAIN:
		case -EAGAIN:
		msleep(EDIF_MSLEEP_INTERVAL);
		cnt++;
		if (cnt < EDIF_RETRY_COUNT)
		@@ -3649,7 +3649,7 @@ int qla_edif_process_els(scsi_qla_host_t vha, struct bsg_job bsg_job)
		p->e.extra_rx_xchg_address, p->e.extra_control_flags,
		sp->handle, sp->remap.req.len, bsg_job);
		break;
		case EAGAIN:
		case -EAGAIN:
		msleep(EDIF_MSLEEP_INTERVAL);
		cnt++;
		if (cnt < EDIF_RETRY_COUNT)