Commit 0689522a authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Guenter Roeck
Browse files

hwmon: (max6639) Simplify with scoped for each OF child loop 



Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251224110702.61746-5-krzysztof.kozlowski@oss.qualcomm.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent bfd0103b

drivers/hwmon/max6639.c

+2 −5
Original line number Diff line number Diff line
@@ -563,7 +563,6 @@ static int max6639_init_client(struct i2c_client *client, 
{

	struct device *dev = &client->dev;

	const struct device_node *np = dev->of_node;

	struct device_node *child;

	int i, err;

	u8 target_duty;
@@ -582,16 +581,14 @@ static int max6639_init_client(struct i2c_client *client, 
	data->target_rpm[0] = 4000;

	data->target_rpm[1] = 4000;



	for_each_child_of_node(np, child) {

	for_each_child_of_node_scoped(np, child) {

		if (strcmp(child->name, "fan"))

			continue;



		err = max6639_probe_child_from_dt(client, child, data);

		if (err) {

			of_node_put(child);

		if (err)

			return err;

	}

	}



	for (i = 0; i < MAX6639_NUM_CHANNELS; i++) {

		err = regmap_set_bits(data->regmap, MAX6639_REG_OUTPUT_MASK, BIT(1 - i));