Commit 06905ea8 authored by Lu Baolu's avatar Lu Baolu Committed by Joerg Roedel
Browse files

iommu/vt-d: Remove SVM_FLAG_PRIVATE_PASID 



The SVM_FLAG_PRIVATE_PASID has never been referenced in the tree, and
there's no plan to have anything to use it. So cleanup it.

Signed-off-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20210323010600.678627-4-baolu.lu@linux.intel.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 2e1a44c1

drivers/iommu/intel/svm.c

+18 −22
Original line number Diff line number Diff line
@@ -465,9 +465,9 @@ intel_svm_bind_mm(struct device *dev, unsigned int flags, 
		  struct mm_struct *mm, struct intel_svm_dev **sd)

{

	struct intel_iommu *iommu = device_to_iommu(dev, NULL, NULL);

	struct intel_svm *svm = NULL, *t;

	struct device_domain_info *info;

	struct intel_svm_dev *sdev;

	struct intel_svm *svm = NULL;

	unsigned long iflags;

	int pasid_max;

	int ret;
@@ -493,11 +493,8 @@ intel_svm_bind_mm(struct device *dev, unsigned int flags, 
		}

	}



	if (!(flags & SVM_FLAG_PRIVATE_PASID)) {

		struct intel_svm *t;



	list_for_each_entry(t, &global_svm_list, list) {

			if (t->mm != mm || (t->flags & SVM_FLAG_PRIVATE_PASID))

		if (t->mm != mm)

			continue;



		svm = t;
@@ -517,7 +514,6 @@ intel_svm_bind_mm(struct device *dev, unsigned int flags, 


		break;

	}

	}



	sdev = kzalloc(sizeof(*sdev), GFP_KERNEL);

	if (!sdev) {

include/linux/intel-svm.h

+3 −13
Original line number Diff line number Diff line
@@ -14,16 +14,6 @@ 
#define SVM_REQ_EXEC	(1<<1)

#define SVM_REQ_PRIV	(1<<0)



/*

 * The SVM_FLAG_PRIVATE_PASID flag requests a PASID which is *not* the "main"

 * PASID for the current process. Even if a PASID already exists, a new one

 * will be allocated. And the PASID allocated with SVM_FLAG_PRIVATE_PASID

 * will not be given to subsequent callers. This facility allows a driver to

 * disambiguate between multiple device contexts which access the same MM,

 * if there is no other way to do so. It should be used sparingly, if at all.

 */

#define SVM_FLAG_PRIVATE_PASID		(1<<0)



/*

 * The SVM_FLAG_SUPERVISOR_MODE flag requests a PASID which can be used only

 * for access to kernel addresses. No IOTLB flushes are automatically done
@@ -35,18 +25,18 @@ 
 * It is unlikely that we will ever hook into flush_tlb_kernel_range() to

 * do such IOTLB flushes automatically.

 */

#define SVM_FLAG_SUPERVISOR_MODE	(1<<1)

#define SVM_FLAG_SUPERVISOR_MODE	BIT(0)

/*

 * The SVM_FLAG_GUEST_MODE flag is used when a PASID bind is for guest

 * processes. Compared to the host bind, the primary differences are:

 * 1. mm life cycle management

 * 2. fault reporting

 */

#define SVM_FLAG_GUEST_MODE		(1<<2)

#define SVM_FLAG_GUEST_MODE		BIT(1)

/*

 * The SVM_FLAG_GUEST_PASID flag is used when a guest has its own PASID space,

 * which requires guest and host PASID translation at both directions.

 */

#define SVM_FLAG_GUEST_PASID		(1<<3)

#define SVM_FLAG_GUEST_PASID		BIT(2)



#endif /* __INTEL_SVM_H__ */