Commit 06ae5afc authored by Denis Benato's avatar Denis Benato Committed by Jiri Kosina
Browse files

HID: hid-asus: add const to read-only outgoing usb buffer 



In the function asus_kbd_set_report the parameter buf is read-only
as it gets copied in a memory portion suitable for USB transfer,
but the parameter is not marked as const: add the missing const and mark
const immutable buffers passed to that function.

Signed-off-by: default avatarDenis Benato <benato.denis96@gmail.com>
Signed-off-by: default avatarLuke D. Jones <luke@ljones.dev>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 5b4ffb17

drivers/hid/hid-asus.c

+4 −4
Original line number Diff line number Diff line
@@ -381,7 +381,7 @@ static int asus_raw_event(struct hid_device *hdev, 
	return 0;

}



static int asus_kbd_set_report(struct hid_device *hdev, u8 *buf, size_t buf_size)

static int asus_kbd_set_report(struct hid_device *hdev, const u8 *buf, size_t buf_size)

{

	unsigned char *dmabuf;

	int ret;
@@ -404,7 +404,7 @@ static int asus_kbd_set_report(struct hid_device *hdev, u8 *buf, size_t buf_size 


static int asus_kbd_init(struct hid_device *hdev)

{

	u8 buf[] = { FEATURE_KBD_REPORT_ID, 0x41, 0x53, 0x55, 0x53, 0x20, 0x54,

	const u8 buf[] = { FEATURE_KBD_REPORT_ID, 0x41, 0x53, 0x55, 0x53, 0x20, 0x54,

		     0x65, 0x63, 0x68, 0x2e, 0x49, 0x6e, 0x63, 0x2e, 0x00 };

	int ret;
@@ -418,7 +418,7 @@ static int asus_kbd_init(struct hid_device *hdev) 
static int asus_kbd_get_functions(struct hid_device *hdev,

				  unsigned char *kbd_func)

{

	u8 buf[] = { FEATURE_KBD_REPORT_ID, 0x05, 0x20, 0x31, 0x00, 0x08 };

	const u8 buf[] = { FEATURE_KBD_REPORT_ID, 0x05, 0x20, 0x31, 0x00, 0x08 };

	u8 *readbuf;

	int ret;
@@ -449,7 +449,7 @@ static int asus_kbd_get_functions(struct hid_device *hdev, 


static int rog_nkey_led_init(struct hid_device *hdev)

{

	u8 buf_init_start[] = { FEATURE_KBD_LED_REPORT_ID1, 0xB9 };

	const u8 buf_init_start[] = { FEATURE_KBD_LED_REPORT_ID1, 0xB9 };

	u8 buf_init2[] = { FEATURE_KBD_LED_REPORT_ID1, 0x41, 0x53, 0x55, 0x53, 0x20,

				0x54, 0x65, 0x63, 0x68, 0x2e, 0x49, 0x6e, 0x63, 0x2e, 0x00 };

	u8 buf_init3[] = { FEATURE_KBD_LED_REPORT_ID1,