Commit 06b919e3 authored by Thomas Böhler's avatar Thomas Böhler Committed by Miguel Ojeda
Browse files

drm/panic: allow verbose version check 

Clippy warns about a reimplementation of `RangeInclusive::contains`:

    error: manual `!RangeInclusive::contains` implementation
       --> drivers/gpu/drm/drm_panic_qr.rs:986:8
        |
    986 |     if version < 1 || version > 40 {
        |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(1..=40).contains(&version)`
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains


        = note: `-D clippy::manual-range-contains` implied by `-D warnings`
        = help: to override `-D warnings` add `#[allow(clippy::manual_range_contains)]`

Ignore this and keep the current implementation as that makes it easier
to read.

Fixes: cb5164ac ("drm/panic: Add a QR code panic screen")
Reported-by: default avatarMiguel Ojeda <ojeda@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1123


Signed-off-by: default avatarThomas Böhler <witcher@wiredspace.de>
Reviewed-by: default avatarJocelyn Falempe <jfalempe@redhat.com>
Link: https://lore.kernel.org/r/20241019084048.22336-8-witcher@wiredspace.de


Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
parent 27aef8a5

drivers/gpu/drm/drm_panic_qr.rs

+1 −0
Original line number Diff line number Diff line
@@ -983,6 +983,7 @@ fn draw_all(&mut self, data: impl Iterator<Item = u8>) { 
/// * If `url_len` = 0, only removes 3 bytes for 1 binary segment.

#[no_mangle]

pub extern "C" fn drm_panic_qr_max_data_size(version: u8, url_len: usize) -> usize {

    #[expect(clippy::manual_range_contains)]

    if version < 1 || version > 40 {

        return 0;

    }