Unverified Commit 06c129ca authored by Rong Zhang's avatar Rong Zhang Committed by Ilpo Järvinen
Browse files

platform/x86: ideapad-laptop: Use str_on_off() helper 



Use the str_on_off() helper instead of open-coding the same operation.
This improves code readability.

No functional change intended.

Suggested-by: default avatarkernel test robot <lkp@intel.com>
Suggested-by: default avatarJulia Lawall <julia.lawall@inria.fr>
Link: https://lore.kernel.org/r/202510311551.xjWbHTrm-lkp@intel.com/


Suggested-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/2bae2ea7-2ef9-0cfa-0c2c-39a7043b2aa5@linux.intel.com/


Signed-off-by: default avatarRong Zhang <i@rong.moe>
Link: https://patch.msgid.link/20251105182832.104946-2-i@rong.moe


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent a9ed446c

drivers/platform/x86/lenovo/ideapad-laptop.c

+8 −7
Original line number Diff line number Diff line
@@ -31,6 +31,7 @@ 
#include <linux/power_supply.h>

#include <linux/rfkill.h>

#include <linux/seq_file.h>

#include <linux/string_choices.h>

#include <linux/sysfs.h>

#include <linux/types.h>

#include <linux/wmi.h>
@@ -462,25 +463,25 @@ static int debugfs_status_show(struct seq_file *s, void *data) 
	if (!read_ec_data(priv->adev->handle, VPCCMD_R_BL, &value))

		seq_printf(s, "Backlight now:  %lu\n", value);

	if (!read_ec_data(priv->adev->handle, VPCCMD_R_BL_POWER, &value))

		seq_printf(s, "BL power value: %s (%lu)\n", value ? "on" : "off", value);

		seq_printf(s, "BL power value: %s (%lu)\n", str_on_off(value), value);



	seq_puts(s, "=====================\n");



	if (!read_ec_data(priv->adev->handle, VPCCMD_R_RF, &value))

		seq_printf(s, "Radio status: %s (%lu)\n", value ? "on" : "off", value);

		seq_printf(s, "Radio status: %s (%lu)\n", str_on_off(value), value);

	if (!read_ec_data(priv->adev->handle, VPCCMD_R_WIFI, &value))

		seq_printf(s, "Wifi status:  %s (%lu)\n", value ? "on" : "off", value);

		seq_printf(s, "Wifi status:  %s (%lu)\n", str_on_off(value), value);

	if (!read_ec_data(priv->adev->handle, VPCCMD_R_BT, &value))

		seq_printf(s, "BT status:    %s (%lu)\n", value ? "on" : "off", value);

		seq_printf(s, "BT status:    %s (%lu)\n", str_on_off(value), value);

	if (!read_ec_data(priv->adev->handle, VPCCMD_R_3G, &value))

		seq_printf(s, "3G status:    %s (%lu)\n", value ? "on" : "off", value);

		seq_printf(s, "3G status:    %s (%lu)\n", str_on_off(value), value);



	seq_puts(s, "=====================\n");



	if (!read_ec_data(priv->adev->handle, VPCCMD_R_TOUCHPAD, &value))

		seq_printf(s, "Touchpad status: %s (%lu)\n", value ? "on" : "off", value);

		seq_printf(s, "Touchpad status: %s (%lu)\n", str_on_off(value), value);

	if (!read_ec_data(priv->adev->handle, VPCCMD_R_CAMERA, &value))

		seq_printf(s, "Camera status:   %s (%lu)\n", value ? "on" : "off", value);

		seq_printf(s, "Camera status:   %s (%lu)\n", str_on_off(value), value);



	seq_puts(s, "=====================\n");