Commit 06f2f68a authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

genirq/generic-chip: Make locking unconditional 



The SMP conditional wrappers around raw_spin_[un]lock() have no real
value. On !SMP kernels the lock operations are NOOPs except for a
preempt_disable/enable() pair on PREEMPT enabled kernels, which are not
really worth to optimize for. Aside of that this evades lockdep on !SMP
kernels.

Remove the !SMP stubs and make it unconditional.

No functional change.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250313142524.011345765@linutronix.de
parent 1902a59c

include/linux/irq.h

+0 −5
Original line number Diff line number Diff line
@@ -1222,7 +1222,6 @@ static inline struct irq_chip_type *irq_data_get_chip_type(struct irq_data *d) 


#define IRQ_MSK(n) (u32)((n) < 32 ? ((1 << (n)) - 1) : UINT_MAX)



#ifdef CONFIG_SMP

static inline void irq_gc_lock(struct irq_chip_generic *gc)

{

	raw_spin_lock(&gc->lock);
@@ -1232,10 +1231,6 @@ static inline void irq_gc_unlock(struct irq_chip_generic *gc) 
{

	raw_spin_unlock(&gc->lock);

}

#else

static inline void irq_gc_lock(struct irq_chip_generic *gc) { }

static inline void irq_gc_unlock(struct irq_chip_generic *gc) { }

#endif



/*

 * The irqsave variants are for usage in non interrupt code. Do not use