Commit 06f77ff9 authored by Rodrigo Gobbi's avatar Rodrigo Gobbi Committed by Vinod Koul
Browse files

soundwire: debugfs: move debug statement outside of error handling 



The start_t and finish_t variables are not properly initialized
if errors happens over request_firmware actions.
This was also detected by smatch:

drivers/soundwire/debugfs.c:301 cmd_go() error: uninitialized symbol 'finish_t'.
drivers/soundwire/debugfs.c:301 cmd_go() error: uninitialized symbol 'start_t'.

Move the debug statement outside of firmware error handling.

Signed-off-by: default avatarRodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-sound/0db6d0bf-7bac-43a7-b624-a00d3d2bf829@stanley.mountain/
Fixes: bb5cb09e ("soundwire: debugfs: add interface for BPT/BRA transfers")
Link: https://lore.kernel.org/r/20250626213628.9575-1-rodrigo.gobbi.7@gmail.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 72bbf6e8

drivers/soundwire/debugfs.c

+3 −3
Original line number Diff line number Diff line
@@ -291,6 +291,9 @@ static int cmd_go(void *data, u64 value) 


	finish_t = ktime_get();



	dev_dbg(&slave->dev, "command completed, num_byte %zu status %d, time %lld ms\n",

		num_bytes, ret, div_u64(finish_t - start_t, NSEC_PER_MSEC));



out:

	if (fw)

		release_firmware(fw);
@@ -298,9 +301,6 @@ static int cmd_go(void *data, u64 value) 
	pm_runtime_mark_last_busy(&slave->dev);

	pm_runtime_put(&slave->dev);



	dev_dbg(&slave->dev, "command completed, num_byte %zu status %d, time %lld ms\n",

		num_bytes, ret, div_u64(finish_t - start_t, NSEC_PER_MSEC));



	return ret;

}

DEFINE_DEBUGFS_ATTRIBUTE(cmd_go_fops, NULL,