Commit 070b3153 authored by Chun-Tse Shao's avatar Chun-Tse Shao Committed by Arnaldo Carvalho de Melo
Browse files

perf test: Restrict uniquifying test to machines with 'uncore_imc' 



The test would fail if target machine does not have 'uncore_imc'
devices.

Since event uniquifying behavior is similar among different
architectures, we are restricting the test to only run on machines with
`uncore_imc` devices.

Suggested-by: default avatarIan Rogers <irogers@google.com>
Signed-off-by: default avatarChun-Tse Shao <ctshao@google.com>
Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250521224513.1104129-1-ctshao@google.com


[ Skip the test, i.e. return 2, instead of returning 0 as if the test had succeed ]
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 44a5ab7a

tools/perf/tests/shell/stat+event_uniquifying.sh

+10 −2
Original line number Diff line number Diff line
@@ -9,7 +9,8 @@ perf_tool=perf 
err=0



test_event_uniquifying() {

  # We use `clockticks` to verify the uniquify behavior.

  # We use `clockticks` in `uncore_imc` to verify the uniquify behavior.

  pmu="uncore_imc"

  event="clockticks"



  # If the `-A` option is added, the event should be uniquified.
@@ -43,11 +44,18 @@ test_event_uniquifying() { 
  echo "stat event uniquifying test"

  uniquified_event_array=()



  # Skip if the machine does not have `uncore_imc` device.

  if ! ${perf_tool} list pmu | grep -q ${pmu}; then

    echo "Target does not support PMU ${pmu} [Skipped]"

    err=2

    return

  fi



  # Check how many uniquified events.

  while IFS= read -r line; do

    uniquified_event=$(echo "$line" | awk '{print $1}')

    uniquified_event_array+=("${uniquified_event}")

  done < <(${perf_tool} list -v ${event} | grep "\[Kernel PMU event\]")

  done < <(${perf_tool} list -v ${event} | grep ${pmu})



  perf_command="${perf_tool} stat -e $event -A -o ${stat_output} -- true"

  $perf_command