Commit 072888fa authored by Pavel Machek's avatar Pavel Machek Committed by Greg Kroah-Hartman
Browse files

[PATCH] PCI Hotplug: fix up coding style issues 



Signed-off-by: default avatarPavel Machek <pavel@suse.cz>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 8169b5d2

drivers/pci/hotplug/acpiphp_ibm.c

+9 −12
Original line number Diff line number Diff line
@@ -449,10 +449,8 @@ static int __init ibm_acpiphp_init(void) 
	}



	ibm_note.device = device;

	status = acpi_install_notify_handler(

			ibm_acpi_handle,

			ACPI_DEVICE_NOTIFY,

			ibm_handle_events,

	status = acpi_install_notify_handler(ibm_acpi_handle,

			ACPI_DEVICE_NOTIFY, ibm_handle_events,

			&ibm_note);

	if (ACPI_FAILURE(status)) {

		err("%s: Failed to register notification handler\n",
@@ -487,9 +485,8 @@ static void __exit ibm_acpiphp_exit(void) 
			   ACPI_DEVICE_NOTIFY,

			   ibm_handle_events);

	if (ACPI_FAILURE(status))

		   err("%s:  Notification handler removal failed\n",

				   __FUNCTION__);

	// remove the /sys entries

		err("%s: Notification handler removal failed\n", __FUNCTION__);

	/* remove the /sys entries */

	if (sysfs_remove_bin_file(sysdir, &ibm_apci_table_attr))

		err("%s: removal of sysfs file apci_table failed\n",

				__FUNCTION__);

drivers/pci/hotplug/ibmphp_core.c

+2 −2
Original line number Diff line number Diff line
@@ -235,12 +235,12 @@ static int set_attention_status(struct hotplug_slot *hotplug_slot, u8 value) 
{

	int rc = 0;

	struct slot *pslot;

	u8 cmd;

	u8 cmd = 0x00;     /* avoid compiler warning */



	debug("set_attention_status - Entry hotplug_slot[%lx] value[%x]\n",

			(ulong) hotplug_slot, value);

	ibmphp_lock_operations();

	cmd = 0x00;     // avoid compiler warning





	if (hotplug_slot) {

		switch (value) {