Commit 072cd5f4 authored by Fenglin Wu's avatar Fenglin Wu Committed by Lee Jones
Browse files

leds: rgb: leds-qcom-lpg: Don't enable TRILED when configuring PWM 



The PWM signal from the LPG channel can be routed to PMIC GPIOs with
proper GPIO configuration, and it is not necessary to enable the
TRILED channel in that case. This also applies to the LPG channels
that mapped to TRILED channels. Additionally, enabling the TRILED
channel unnecessarily would cause a voltage increase in its power
supply. Hence remove it.

Fixes: 24e2d05d ("leds: Add driver for Qualcomm LPG")
Signed-off-by: default avatarFenglin Wu <fenglin.wu@oss.qualcomm.com>
Reviewed-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://patch.msgid.link/20251119-lpg_triled_fix-v3-2-84b6dbdc774a@oss.qualcomm.com


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 5d390e7a

drivers/leds/rgb/leds-qcom-lpg.c

+1 −3
Original line number Diff line number Diff line
@@ -2,7 +2,7 @@ 
/*

 * Copyright (c) 2017-2022 Linaro Ltd

 * Copyright (c) 2010-2012, The Linux Foundation. All rights reserved.

 * Copyright (c) 2023-2024, Qualcomm Innovation Center, Inc. All rights reserved.

 * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.

 */

#include <linux/bits.h>

#include <linux/bitfield.h>
@@ -1247,8 +1247,6 @@ static int lpg_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, 


	lpg_apply(chan);



	triled_set(lpg, chan->triled_mask, chan->enabled ? chan->triled_mask : 0);



out_unlock:

	mutex_unlock(&lpg->lock);