Commit 07c88883 authored by Tudor Ambarus's avatar Tudor Ambarus Committed by Pratyush Yadav
Browse files

mtd: spi-nor: use local variable for struct device 



Use a local variable for the struct device pointers to avoid
dereferencing.

Signed-off-by: default avatarTudor Ambarus <tudor.ambarus@linaro.org>
Reviewed-by: default avatarPratyush Yadav <pratyush@kernel.org>
Signed-off-by: default avatarPratyush Yadav <pratyush@kernel.org>
Link: https://lore.kernel.org/r/20241111111946.9048-2-tudor.ambarus@linaro.org
parent e7f4e924

drivers/mtd/spi-nor/core.c

+7 −7
Original line number Diff line number Diff line
@@ -3576,7 +3576,8 @@ static int spi_nor_create_write_dirmap(struct spi_nor *nor) 
static int spi_nor_probe(struct spi_mem *spimem)

{

	struct spi_device *spi = spimem->spi;

	struct flash_platform_data *data = dev_get_platdata(&spi->dev);

	struct device *dev = &spi->dev;

	struct flash_platform_data *data = dev_get_platdata(dev);

	struct spi_nor *nor;

	/*

	 * Enable all caps by default. The core will mask them after
@@ -3586,13 +3587,13 @@ static int spi_nor_probe(struct spi_mem *spimem) 
	char *flash_name;

	int ret;



	nor = devm_kzalloc(&spi->dev, sizeof(*nor), GFP_KERNEL);

	nor = devm_kzalloc(dev, sizeof(*nor), GFP_KERNEL);

	if (!nor)

		return -ENOMEM;



	nor->spimem = spimem;

	nor->dev = &spi->dev;

	spi_nor_set_flash_node(nor, spi->dev.of_node);

	nor->dev = dev;

	spi_nor_set_flash_node(nor, dev->of_node);



	spi_mem_set_drvdata(spimem, nor);
@@ -3628,9 +3629,8 @@ static int spi_nor_probe(struct spi_mem *spimem) 
	 */

	if (nor->params->page_size > PAGE_SIZE) {

		nor->bouncebuf_size = nor->params->page_size;

		devm_kfree(nor->dev, nor->bouncebuf);

		nor->bouncebuf = devm_kmalloc(nor->dev,

					      nor->bouncebuf_size,

		devm_kfree(dev, nor->bouncebuf);

		nor->bouncebuf = devm_kmalloc(dev, nor->bouncebuf_size,

					      GFP_KERNEL);

		if (!nor->bouncebuf)

			return -ENOMEM;