Commit 07caaf87 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

netlink: specs: ethtool: replace underscores with dashes in names 



We're trying to add a strict regexp for the name format in the spec.
Underscores will not be allowed, dashes should be used instead.
This makes no difference to C (codegen replaces special chars in names)
but gives more uniform naming in Python.

Fixes: 13e59344 ("net: ethtool: add support for symmetric-xor RSS hash")
Fixes: 46fb3ba9 ("ethtool: Add an interface for flashing transceiver modules' firmware")
Reviewed-by: default avatarKory Maincent <kory.maincent@bootlin.com>
Reviewed-by: default avatarDonald Hunter <donald.hunter@gmail.com>
Link: https://patch.msgid.link/20250624211002.3475021-4-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 791a9ed0

Documentation/netlink/specs/ethtool.yaml

+3 −3
Original line number Diff line number Diff line
@@ -48,7 +48,7 @@ definitions: 
        name: started

        doc: The firmware flashing process has started.

      -

        name: in_progress

        name: in-progress

        doc: The firmware flashing process is in progress.

      -

        name: completed
@@ -1422,7 +1422,7 @@ attribute-sets: 
        name: hkey

        type: binary

      -

        name: input_xfrm

        name: input-xfrm

        type: u32

      -

        name: start-context
@@ -2238,7 +2238,7 @@ operations: 
            - hfunc

            - indir

            - hkey

            - input_xfrm

            - input-xfrm

      dump:

        request:

          attributes:

tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py

+1 −1
Original line number Diff line number Diff line
@@ -38,7 +38,7 @@ def test_rss_input_xfrm(cfg, ipver): 
        raise KsftSkipEx("socket.SO_INCOMING_CPU was added in Python 3.11")



    input_xfrm = cfg.ethnl.rss_get(

        {'header': {'dev-name': cfg.ifname}}).get('input_xfrm')

        {'header': {'dev-name': cfg.ifname}}).get('input-xfrm')



    # Check for symmetric xor/or-xor

    if not input_xfrm or (input_xfrm != 1 and input_xfrm != 2):