Commit 07d91ec9 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: stmmac: rearrange tc_init() 



To make future changes easier, rearrange the use of dma_cap->l3l4fnum
vs priv->flow_entries_max.

Always initialise priv->flow_entries_max from dma_cap->l3l4fnum, then
use priv->flow_entries_max to determine whether we allocate
priv->flow_entries and set it up.

This change is safe because tc_init() is only called once from
stmmac_dvr_probe().

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarMaxime Chevallier <maxime.chevallier@bootlin.com>
Link: https://patch.msgid.link/E1v945Y-0000000Ameb-2gDI@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e82c64be

drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c

+3 −3
Original line number Diff line number Diff line
@@ -262,10 +262,10 @@ static int tc_init(struct stmmac_priv *priv) 
	unsigned int count;

	int ret, i;



	if (dma_cap->l3l4fnum) {

	priv->flow_entries_max = dma_cap->l3l4fnum;

	if (priv->flow_entries_max) {

		priv->flow_entries = devm_kcalloc(priv->device,

						  dma_cap->l3l4fnum,

						  priv->flow_entries_max,

						  sizeof(*priv->flow_entries),

						  GFP_KERNEL);

		if (!priv->flow_entries)