Commit 07ed4f05 authored by Bart Van Assche's avatar Bart Van Assche Committed by Guenter Roeck
Browse files

hwmon: (it87) Check the it87_lock() return value 



Return early in it87_resume() if it87_lock() fails instead of ignoring the
return value of that function. This patch suppresses a Clang thread-safety
warning.

Cc: Frank Crawford <frank@crawford.emu.id.au>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>
Cc: linux-hwmon@vger.kernel.org
Fixes: 376e1a93 ("hwmon: (it87) Add calls to smbus_enable/smbus_disable as required")
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20260223220102.2158611-15-bart.vanassche@linux.dev


[groeck: Declare 'ret' at the beginning of it87_resume()]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent e710b228

drivers/hwmon/it87.c

+4 −1
Original line number Diff line number Diff line
@@ -3590,10 +3590,13 @@ static int it87_resume(struct device *dev) 
{

	struct platform_device *pdev = to_platform_device(dev);

	struct it87_data *data = dev_get_drvdata(dev);

	int err;



	it87_resume_sio(pdev);



	it87_lock(data);

	err = it87_lock(data);

	if (err)

		return err;



	it87_check_pwm(dev);

	it87_check_limit_regs(data);