Commit 0859eb54 authored by Shikang Fan's avatar Shikang Fan Committed by Alex Deucher
Browse files

drm/amdgpu: Check fence emitted count to identify bad jobs 



In SRIOV, when host driver performs MODE 1 reset and notifies FLR to
guest driver, there is a small chance that there is no job running on hw
but the driver has not updated the pending list yet, causing the driver
not respond the FLR request. Modify the has_job_running function to
make sure if there is still running job.

v2: Use amdgpu_fence_count_emitted to determine job running status.
v3: Remove the timeout wait in has_job_running

Signed-off-by: default avatarEmily Deng <Emily.Deng@amd.com>
Signed-off-by: default avatarShikang Fan <shikang.fan@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 9aa879da

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

+6 −8
Original line number Diff line number Diff line
@@ -5238,16 +5238,18 @@ static int amdgpu_device_reset_sriov(struct amdgpu_device *adev, 
}



/**

 * amdgpu_device_has_job_running - check if there is any job in mirror list

 * amdgpu_device_has_job_running - check if there is any unfinished job

 *

 * @adev: amdgpu_device pointer

 *

 * check if there is any job in mirror list

 * check if there is any job running on the device when guest driver receives

 * FLR notification from host driver. If there are still jobs running, then

 * the guest driver will not respond the FLR reset. Instead, let the job hit

 * the timeout and guest driver then issue the reset request.

 */

bool amdgpu_device_has_job_running(struct amdgpu_device *adev)

{

	int i;

	struct drm_sched_job *job;



	for (i = 0; i < AMDGPU_MAX_RINGS; ++i) {

		struct amdgpu_ring *ring = adev->rings[i];
@@ -5255,11 +5257,7 @@ bool amdgpu_device_has_job_running(struct amdgpu_device *adev) 
		if (!amdgpu_ring_sched_ready(ring))

			continue;



		spin_lock(&ring->sched.job_list_lock);

		job = list_first_entry_or_null(&ring->sched.pending_list,

					       struct drm_sched_job, list);

		spin_unlock(&ring->sched.job_list_lock);

		if (job)

		if (amdgpu_fence_count_emitted(ring))

			return true;

	}

	return false;