Commit 0899bab9 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Linus Walleij
Browse files

pinctrl: tegra-xusb: Return void in padctl enable/disable functions 



Make the padctl functions a bit simpler by returning void instead of
always '0'.  The callers - phy init/exit - still need to return 0, but
these are smaller function without if/branching.

Acked-by: default avatarThierry Reding <treding@nvidia.com>
Reviewed-by: default avatarJon Hunter <jonathanh@nvidia.com>
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: default avatarLinus Walleij <linusw@kernel.org>
parent b339e1df

drivers/pinctrl/tegra/pinctrl-tegra-xusb.c

+8 −6
Original line number Diff line number Diff line
@@ -474,7 +474,7 @@ static const struct pinconf_ops tegra_xusb_padctl_pinconf_ops = { 
#endif

};



static int tegra_xusb_padctl_enable(struct tegra_xusb_padctl *padctl)

static void tegra_xusb_padctl_enable(struct tegra_xusb_padctl *padctl)

{

	u32 value;
@@ -501,10 +501,9 @@ static int tegra_xusb_padctl_enable(struct tegra_xusb_padctl *padctl) 


out:

	mutex_unlock(&padctl->lock);

	return 0;

}



static int tegra_xusb_padctl_disable(struct tegra_xusb_padctl *padctl)

static void tegra_xusb_padctl_disable(struct tegra_xusb_padctl *padctl)

{

	u32 value;
@@ -534,21 +533,24 @@ static int tegra_xusb_padctl_disable(struct tegra_xusb_padctl *padctl) 


out:

	mutex_unlock(&padctl->lock);

	return 0;

}



static int tegra_xusb_phy_init(struct phy *phy)

{

	struct tegra_xusb_padctl *padctl = phy_get_drvdata(phy);



	return tegra_xusb_padctl_enable(padctl);

	tegra_xusb_padctl_enable(padctl);



	return 0;

}



static int tegra_xusb_phy_exit(struct phy *phy)

{

	struct tegra_xusb_padctl *padctl = phy_get_drvdata(phy);



	return tegra_xusb_padctl_disable(padctl);

	tegra_xusb_padctl_disable(padctl);



	return 0;

}



static int pcie_phy_power_on(struct phy *phy)