Commit 08cc4c39 authored by Kevin Brodsky's avatar Kevin Brodsky Committed by Andrew Morton
Browse files

selftests/mm: remove X permission from sigaltstack mapping 

There is no reason why the alternate signal stack should be mapped as RWX.
Map it as RW instead.

Link: https://lkml.kernel.org/r/20241209095019.1732120-15-kevin.brodsky@arm.com


Signed-off-by: default avatarKevin Brodsky <kevin.brodsky@arm.com>
Cc: Aruna Ramakrishna <aruna.ramakrishna@oracle.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Joey Gouly <joey.gouly@arm.com>
Cc: Keith Lucas <keith.lucas@oracle.com>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 1c6b1d48

tools/testing/selftests/mm/pkey_sighandler_tests.c

+2 −2
Original line number Diff line number Diff line
@@ -315,7 +315,7 @@ static void test_sigsegv_handler_with_different_pkey_for_stack(void) 
	sys_mprotect_pkey(stack, STACK_SIZE, PROT_READ | PROT_WRITE, pkey);



	/* Set up alternate signal stack that will use the default MPK */

	sigstack.ss_sp = mmap(0, STACK_SIZE, PROT_READ | PROT_WRITE | PROT_EXEC,

	sigstack.ss_sp = mmap(0, STACK_SIZE, PROT_READ | PROT_WRITE,

			      MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);

	sigstack.ss_flags = 0;

	sigstack.ss_size = STACK_SIZE;
@@ -488,7 +488,7 @@ static void test_pkru_sigreturn(void) 
	sys_mprotect_pkey(stack, STACK_SIZE, PROT_READ | PROT_WRITE, pkey);



	/* Set up alternate signal stack that will use the default MPK */

	sigstack.ss_sp = mmap(0, STACK_SIZE, PROT_READ | PROT_WRITE | PROT_EXEC,

	sigstack.ss_sp = mmap(0, STACK_SIZE, PROT_READ | PROT_WRITE,

			      MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);

	sigstack.ss_flags = 0;

	sigstack.ss_size = STACK_SIZE;