Commit 08fa656c authored by Dan Carpenter's avatar Dan Carpenter Committed by Felix Fietkau
Browse files

wifi: mt76: mt7925: fix off by one in mt7925_load_clc() 



This comparison should be >= instead of > to prevent an out of bounds
read and write.

Fixes: 9679ca73 ("wifi: mt76: mt7925: fix a potential array-index-out-of-bounds issue for clc")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/84bf5dd2-2fe3-4410-a7af-ae841e41082a@stanley.mountain


Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent fbce6136

drivers/net/wireless/mediatek/mt76/mt7925/mcu.c

+1 −1
Original line number Diff line number Diff line
@@ -638,7 +638,7 @@ static int mt7925_load_clc(struct mt792x_dev *dev, const char *fw_name) 
	for (offset = 0; offset < len; offset += le32_to_cpu(clc->len)) {

		clc = (const struct mt7925_clc *)(clc_base + offset);



		if (clc->idx > ARRAY_SIZE(phy->clc))

		if (clc->idx >= ARRAY_SIZE(phy->clc))

			break;



		/* do not init buf again if chip reset triggered */