Unverified Commit 0902010c authored by Felix Gu's avatar Felix Gu Committed by Mark Brown
Browse files

regulator: fp9931: Fix PM runtime reference leak in fp9931_hwmon_read() 



In fp9931_hwmon_read(), if regmap_read() failed, the function returned
the error code without calling pm_runtime_put_autosuspend(), causing
a PM reference leak.

Fixes: 12d821bd ("regulator: Add FP9931/JD9930 driver")
Signed-off-by: default avatarFelix Gu <ustc.gu@gmail.com>
Reviewed-by: default avatarAndreas Kemnade <andreas@kemnade.info>
Link: https://patch.msgid.link/20260224-fp9931-v1-1-1cf05cabef4a@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4b73231b

drivers/regulator/fp9931.c

+3 −4
Original line number Diff line number Diff line
@@ -144,13 +144,12 @@ static int fp9931_hwmon_read(struct device *dev, enum hwmon_sensor_types type, 
		return ret;



	ret = regmap_read(data->regmap, FP9931_REG_TMST_VALUE, &val);

	if (ret)

		return ret;

	if (!ret)

		*temp = (s8)val * 1000;



	pm_runtime_put_autosuspend(data->dev);

	*temp = (s8)val * 1000;



	return 0;

	return ret;

}



static umode_t fp9931_hwmon_is_visible(const void *data,