Commit 0917ed8f authored by Niklas Cassel's avatar Niklas Cassel Committed by Bjorn Helgaas
Browse files

PCI: endpoint: Align pci_epc_get_msix(), pci_epc_ops::get_msix() return value encoding 



The kdoc for pci_epc_get_msix() says:
"Invoke to get the number of MSI-X interrupts allocated by the RC"

The kdoc for the callback pci_epc_ops->get_msix() says:
"ops to get the number of MSI-X interrupts allocated by the RC from the
MSI-X capability register"

pci_epc_ops::get_msix() does however return the number of interrupts in the
encoding as defined by the Table Size field. Nowhere in the kdoc does it
say that the returned number of interrupts is in Table Size encoding.

It is very confusing that the API pci_epc_get_msix() and the callback
function pci_epc_ops::get_msix() don't return the same value.

Clean up the API and the callback function to have the same semantics,
i.e. return the number of interrupts, regardless of the internal encoding
of that value.

[bhelgaas: more specific subject]

Signed-off-by: default avatarNiklas Cassel <cassel@kernel.org>
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Cc: stable+noautosel@kernel.org # this is simply a cleanup
Link: https://patch.msgid.link/20250514074313.283156-12-cassel@kernel.org
parent f7f15fc5

drivers/pci/controller/cadence/pcie-cadence-ep.c

+1 −1
Original line number Diff line number Diff line
@@ -281,7 +281,7 @@ static int cdns_pcie_ep_get_msix(struct pci_epc *epc, u8 func_no, u8 vfunc_no) 


	val &= PCI_MSIX_FLAGS_QSIZE;



	return val;

	return val + 1;

}



static int cdns_pcie_ep_set_msix(struct pci_epc *epc, u8 fn, u8 vfn,

drivers/pci/controller/dwc/pcie-designware-ep.c

+1 −1
Original line number Diff line number Diff line
@@ -575,7 +575,7 @@ static int dw_pcie_ep_get_msix(struct pci_epc *epc, u8 func_no, u8 vfunc_no) 


	val &= PCI_MSIX_FLAGS_QSIZE;



	return val;

	return val + 1;

}



static int dw_pcie_ep_set_msix(struct pci_epc *epc, u8 func_no, u8 vfunc_no,

drivers/pci/endpoint/pci-epc-core.c

+1 −1
Original line number Diff line number Diff line
@@ -355,7 +355,7 @@ int pci_epc_get_msix(struct pci_epc *epc, u8 func_no, u8 vfunc_no) 
	if (interrupt < 0)

		return 0;



	return interrupt + 1;

	return interrupt;

}

EXPORT_SYMBOL_GPL(pci_epc_get_msix);