Commit 09680274 authored by Miklos Szeredi's avatar Miklos Szeredi
Browse files

ovl: remove upper umask handling from ovl_create_upper() 



This is already done by vfs_prepare_mode() when creating the upper object
by vfs_create(), vfs_mkdir() and vfs_mknod().

No regressions have been observed in xfstests run with posix acls turned
off for the upper filesystem.

Fixes: 1639a49c ("fs: move S_ISGID stripping into the vfs_*() helpers")
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
parent 9a87907d

fs/overlayfs/dir.c

+0 −3
Original line number Diff line number Diff line
@@ -330,9 +330,6 @@ static int ovl_create_upper(struct dentry *dentry, struct inode *inode, 
	struct dentry *newdentry;

	int err;



	if (!attr->hardlink && !IS_POSIXACL(udir))

		attr->mode &= ~current_umask();



	inode_lock_nested(udir, I_MUTEX_PARENT);

	newdentry = ovl_create_real(ofs, udir,

				    ovl_lookup_upper(ofs, dentry->d_name.name,