Commit 09773978 authored Mar 26, 2026 by Sanman Pradhan Committed by Guenter Roeck Mar 30, 2026

hwmon: (occ) Fix missing newline in occ_show_extended()



In occ_show_extended() case 0, when the EXTN_FLAG_SENSOR_ID flag
is set, the sysfs_emit format string "%u" is missing the trailing
newline that the sysfs ABI expects. The else branch correctly uses
"%4phN\n", and all other show functions in this file include the
trailing newline.

Add the missing "\n" for consistency and correct sysfs output.

Fixes: c10e753d ("hwmon (occ): Add sensor types and versions")
Signed-off-by: Sanman Pradhan <psanman@juniper.net>
Link: https://lore.kernel.org/r/20260326224510.294619-3-sanman.pradhan@hpe.com


Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 39e2a5bf

drivers/hwmon/occ/common.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -724,7 +724,7 @@ static ssize_t occ_show_extended(struct device *dev,
		switch (sattr->nr) {
		case 0:
		if (extn->flags & EXTN_FLAG_SENSOR_ID) {
		rc = sysfs_emit(buf, "%u",
		rc = sysfs_emit(buf, "%u\n",
		get_unaligned_be32(&extn->sensor_id));
		} else {
		rc = sysfs_emit(buf, "%4phN\n", extn->name);